Skip to content

Conversation

@sudarshan12s
Copy link
Member

@sudarshan12s sudarshan12s commented Nov 26, 2025

langchain-oracle/
│
├── libs/                
│   └── ... (existing code for python. This can be moved inside python?)
│   ├── js/oracledb/langchain-oracledb/
           |_____________________________ package.json
│          |_____________________________  src/
│          |_____________________________ tests/
│          |_____________________________tsconfig.json
│          |_____________________________ CONTRIBUTING.md    (optional)
│          |_____________________________ THIRD_PARTY_LICENSES.txt
│
├── .github/               (only ONE, at root)
│   ├── workflows/
│   │   ├── python-ci.yml
│   │   ├── js-ci.yml
│   │   └── lint.yml
│   ├── ISSUE_TEMPLATE/
│   ├── SECURITY.md
│   └── PULL_REQUEST_TEMPLATE.md
│
└── README.md              (explains the monorepo)

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 26, 2025
@YouNeedCryDear
Copy link
Member

YouNeedCryDear commented Nov 26, 2025

I prefer keeping the python folder intact, then javascript living under js folder under the root directory.
Or entirely reorg as

libs/
  python/
    oci/
    oracledb/
  js/
    oracledb/

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 27, 2025
@sudarshan12s
Copy link
Member Author

I prefer keeping the python folder intact, then javascript living under js folder under the root directory. Or entirely reorg as

libs/
  python/
    oci/
    oracledb/
  js/
    oracledb/

Thanks.
I have created this structure for js, If we are ok with creating python folder, I can move current folders inside libs to libs/python

langchain-oracle/libs/js/oracledb/langchain-oracledb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants